-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ros2 bag play for split bags #268
Fix ros2 bag play for split bags #268
Conversation
142a59d
to
5f74acb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM pending green CI.
@ros2/aws-oncall - please run this CI job |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you link to an issue / failing tests which is indicating this problem? This very much sounds like a regression to me and I wonder why we haven't figured this one out earlier.
If there's no test available, I very much require to extend this PR to have one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
with green CI
It looks like there's also some sort of regression in |
5f74acb
to
f00c4c7
Compare
Signed-off-by: Zachary Michaels <zmichaels11@gmail.com>
f00c4c7
to
c342edb
Compare
CI job |
Fixes problem where
SequentialReader
is not loading storage from split bagfiles.